Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Core] Fix optical sensor firmware upload #15919

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 18, 2022

Description

Fix and properly handle uploading the progmem firmware blob for the pmw 33xx sensors.

Types of Changes

  • Core
  • Bugfix
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna changed the title [Bug][Core] Fix pmw33xx firmware upload [Bug][Core] Fix optical sensor firmware upload Jan 18, 2022
@daskygit
Copy link
Member

FWIW testing the ADNS change with a promicro the default option works but enabling the fast option doesn't

@drashna
Copy link
Member Author

drashna commented Jan 19, 2022

FWIW testing the ADNS change with a promicro the default option works but enabling the fast option doesn't

Will remove then. Odd, though.

@drashna drashna requested a review from a team January 19, 2022 02:07
@drashna drashna merged commit 6ebb44f into qmk:develop Jan 20, 2022
@drashna drashna deleted the fix/pmw_upload branch January 20, 2022 17:23
drashna added a commit to drashna/qmk_firmware that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants